Design comparison
Solution retrospective
Hello, any feedback would be greatly appreciated.
Thank you.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello there! ๐
Congratulations on completing this challenge! ๐ Good job on using Normalize on the site! ๐
However, there are some areas that can be improved.
- Use
min-height
instead ofheight
on thebody
element. This way, if the card element needs more than100vh
then thebody
element can grow (by adding a vertical scrollbar) which means that the users can scroll to see the rest of the content. - Create a custom
:focus-visible
styling to any interactive elements (button
, links,input
,textarea
). This will make the users can navigate this website using keyboard (by usingTab
key).
Hope you find this useful!
Marked as helpful0@GSD3v08Posted over 2 years ago@vanzasetia , Thank you for your feedback , I made the changes you suggested. I'll try to do the same in next challenges.
0@vanzasetiaPosted over 2 years ago@GSD3v08 You're welcome! I took a look at the site and I would recommend making the
:focus-visible
styling usingoutline
only. The purpose is to make the styling stand out from the:hover
or:active
states. So, the only time where the element has an outline is when it gets focused.0@vanzasetiaPosted over 2 years ago@GSD3v08 Yup! Now, it is stand out with a white outline! Great job with the update! ๐
1 - Use
- @Kamasah-DicksonPosted over 2 years ago
Great solution, your texts are readable on smaller screens and responsive. Good job there๐ Happy coding๐
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord