Design comparison
SolutionDesign
Community feedback
- @denieldenPosted about 2 years ago
Hi Jonathan, congratulations on completing the challenge, great job! 😁
Some little tips for optimizing your code:
- add
main
tag and wrap the card for improve the Accessibility - use
h1
for the title of card andh2
for subtitle instead of a simplep
- use
button
tag for the button not a styledp
- use
min-height: 100vh
to.body-wrapper
class instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😉
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord