@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
marginorpadding.
- We don't need to use
marginandpaddingto center the component both horizontally & vertically. Because usingmarginorpaddingwill not dynamical centers our component at all states
- To properly center the component in the page, you should use
FlexboxorGridlayout. You can read more about centering in CSS here 📚.
- For this demonstration we use css
Gridto center the component.
body {
min-height: 100vh;
display: grid;
place-items: center;
}
- Now remove these styles, after removing you can able to see the changes
@media screen and (min-width: 42.5rem)
.main-container {
padding: 160px;
}
.main-container {
padding: 73px 31px 73px 31px;
}
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@brayanlegarda1
Posted
@0xAbdulKhalid
Hello friend, first I want to thank you for taking the time to review the code.
regarding your suggestion of how to center the element. I will take it into account and make the respective correction.
I have a question: once an element is centered. for example a <p> element that contains a text.
How do we make the paragraph look like the guide?
with line breaks for example
I say this because at first I applied the padding and margins so that the paragraphs were the closest thing to the prototype. so that the line breaks were given as in the guide. and the width of each paragraph was the most similar
thanks again for your help
