Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="container"> with the main tag, the first <h3> with <h2> and the first <h6> with <p> to fix the accessibility issue. click here for more on web-accessibility and semantic html
To center .container on the page using flexbox, add min-height:100vh to the body.
Give .container a fixe width value instead of a percentage width value. e.g:
width: 600px;
give . join-community, .Signup and .whyus the same padding value for all the sides.
padding: 50px
.There is no need to give .conatiner a height value in the media query. the padding value will be good for that but reduce the padding value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord