Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Single Price Grid Component

@nmrtsnh

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone,

I am Namrata and this is my solution for the Single Price Grid Component challenge.

If you have any suggestions to improve my code, please feel free to share!

Thank you 🙏

Community feedback

P

@Islandstone89

Posted

HTML:

  • Make .container a <main>.

  • Headings should always be in order, so you would never start with a <h4>. Change it to a <h1>.

CSS:

  • Performance-wise it's better to link the fonts in the <head> of the HTML, instead of using @import.

  • Font-size must never be in px. Use rem instead.

  • height on body should be min-height.

  • Remove margin: 0 auto on body.

  • max-width on container should be in rem.

Marked as helpful

0

@nmrtsnh

Posted

@Islandstone89 Thanks for the feedback! I implemented it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord