Design comparison
Solution retrospective
Hello.
This was my first attempt at having that sort of mixed with columns and multiple rows on the desktop/laptop sizes.
How is the method used for the shift between desktop and mobile sizes? Maybe it just feels abrupt to me because I am just sitting there stretching the size of my browser window, but I don't know how well it looks.
Community feedback
- @NaveenGumastePosted almost 3 years ago
Hello Taylor ! Congo π on completing this challenge
Let's look at some of your issues, shall we:
-
The background color is given in style-guide.md
-
Why us section color is too much light and i know it was not given in style-guide so use color-zilla chrome extension. and you will get the color
-
This is color i used for my solution
--light-cyan: hsl(179, 45%, 52%);
check my solution here if needed -
Warp your card content around the main tag Ex: π
<body> <main class="container"> *all you content here* </main> </body>
happy Codingπ
Marked as helpful0 -
- @denieldenPosted almost 3 years ago
Hi Taylor, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - remove
padding
fromfluid-container
and setmax-width
- To make it look as close to the design as possible the
background
of first block iswhite
- use flexbox to the body for center the box. Read here -> best flex guide
- after add
min-heigth: 100vh
to body because Flexbox aligns to the size of the parent container
Overall you did well :)
Hope this help and happy coding!
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord