Design comparison
Solution retrospective
Please tell me if i can style this any better
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Drew, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Every page should have one main landmark
<main>. So replace the div that wraps the whole content with<main>to improve the accessibility. click here2- All page content should be contained by landmarks, you can understand better by clicking here: click here
We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
2- Why it Matters
Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.
Rule Description
It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.
Link to read more about: click here
Prefer to use
removerpxto have your page working better across browsers and resizing the elements properlyThe rest is great!!
Hope it helps...👍
Marked as helpful0 - @edufelibugmPosted about 2 years ago
Hi bro!! congratulations on your solution! 🥳🥳
Your design looks good, but it can be improved 🦾
🔧 any tips:
-
Your body has a
display: flex;this causes the footer to be positioned next to your container, you can fix this by setting the propertyflex-direction: column;. 🖥 -
You could add a
:hoversubclass on your button to make it have some animation, you can just add anopacity: .5; transition: .5s ease-in-out. ✍
that's all, the rest is just keep practicing 😌
Have a great day and happy coding 🤖💚
Marked as helpful0 -
- @AatypicPosted about 2 years ago
Hello and congratulations on your solution !
Concerning styling, to make it better:
-Like asked in the challenge you could add an active state
:hoveron the sign up button to make it stand out.-Also I'm almost sure that the 3rd card "Why us" beneath the header those are links. You could make a list instead of a <p>
-And for the whole container you can remove the your fixed margin-top or any other margins, and instead center it with <body> you already have flex on it. But for that to work you need the following you are missing:
min-height:100vhon your<body>.Good luck ✌️
Marked as helpful0@andex23Posted about 2 years ago@Aatypic Thank You, I appreciate your input. I didn’t think the 3rd card was a link, using the <p> tag was easier for me.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord