Design comparison
SolutionDesign
Community feedback
- @tea-scriptsPosted over 2 years ago
Great work completing the project. Just some things you could work on:
- Having a
max-width
on your container would make your display look much better and would control how wide your container spans on the page. - Placing your entire markup in the
<main>
would take care of the accessibility issue of the landmark and also keep your markup organized. In your free time learn more about landmarks and how you can make use of them for accessibility. - When using heading tags always start with
h1
thenh2
,h3
and so on. You can’t start usingh2
without previously usingh1
.
Great work so far mate.. keep rocking it 👍!
Marked as helpful0 - Having a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord