HTML & CSS for Price_grid_card

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Congrats on completing your first challenge!🎊🎆

  • The incorrect colors ❌ are being used, I suggest looking at the "style-guide" to get the correct ones.

  • To properly center ✅ your content to your page, you will want to add the following to your body (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info: 📚

  Centering in CSS

  • The headings are being used incorrectly ❌. For this component, you will only use the <h1> for “Join our community” and <h2> for “Monthly Subscription” and “Why us.”

  • The button was created with the incorrect element ❌. When users click on the button they should directed to a different part of your site; the anchor element will allow this to happen.

  More Info:📚

  MDN The Anchor element

  • The “Why Us” list needs to be created using an unordered list ⚠️ element along with the list item element.

  MDN Unordered List Element

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property values. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  0

  ---

  

  Renish Okago•220

  @fabrizia2Posted almost 2 years ago

  @vcarames Thanks for the feedback

  0