
Submitted over 3 years ago
Single Price Grid Component - Methodology BEM - GRID+FLEX
@richardtr123
Design comparison
SolutionDesign
Solution retrospective
Guys, some advice for the responsive of a grid, the size especially
Community feedback
- P@kens-visualsPosted over 3 years ago
Hey @richardtr123 👋🏻
I have some suggestions to help you fix the accessibility issues and some other things.
- In your markup,
<div class="card">...</div>
should be<main class="card">...</main>
. This will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues. - I won't go into details about resetting CSS, but I'll leave this cool article here, which will make more sense than my brief explanation.
- Next, the footer should be at the bottom of the page.
- The text in the bottom right block should be in
ul li
because it's a list.
I hope this was helpful 👨🏻💻 other than that, you did a nice job, especially with responsiveness, nicely done. Cheers 👾
Marked as helpful0 - In your markup,
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord