Single Price Grid Component Master

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted almost 4 years ago

  Hi @Art-wdt nice job on this one - the page looks good and you've some nice responsiveness working there. Some suggestions:

  1. You don't need to wrap everything in a <div>. You could try removing some of the div wrappers around your heading tags. If you want to keep the class names just add them onto these elements directly. They are all block level elements so should work the same way.

  2. Similarly when you just have some text use a <p> rather than a div. Again these are also block level elements so will work the same way. This will make your code simpler, easier to read, and more semantic. The use of the <ul> in your code is a good example of this. The best element for the job. It's just a good habit to get into.

  Lastly if you really wanted to explore flexbox some more you could try doing the layout with one flexbox rather than two... You would need to add different flex-basis to the top element and the following two, but you might have fund trying....

  Nice work. Keep up the good coding!

  2

  ---

  

  Art•420

  @Art-wdtPosted over 3 years ago

  Hi @dwhenson Thanks for your detailed advice. This is important to me.

  I will gladly study the theoretical part. To be able to put your advice into practice.

  0