Design comparison
Community feedback
- @gregoriofrancisco99Posted almost 2 years ago
Hello, Liya. Congratulations for your submission 🥂 Your design looks awesome, but there’s a little room for improvement. ☺️
Took a look at your html, and one of the best practices is to use semantic and more meaningful tags instead of using div, a generic and low meaning tag, everywhere. This article should help you getting started. 👌
In total there are six type of headings, and h2 is a level two heading which you can have as many time as you need. This article should help.
Noticed you had a hard time trying to center the content. Well, the following code should help
body { width: 100%; height: 100vh; } #card { Width: 910px; /* for example*/ Margin: auto; }
Other good solution would be to use the
flexbox
property.Well, hope I was able to help! And remember... keep coding 💻
Marked as helpful0@Liya-amPosted almost 2 years ago@gregoriofrancisco99 Thank you so much, the centering part was really what bothered me.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord