Vanza Setia• 27,795
@vanzasetia
Posted
👋Hi Nene! My name is Vanza!
I have some feedback on this solution, that may improve this solution:
- For the
container, I recommend to usemax-widthas a default style, not inside@media all and (min-width:1024px). The problem with putting thewidthinside this media query is that, it will only applied when the screen is1024pxand above. So, when the screen size is960pxthecontainerwill become too wide. - For the zero number, the best practice is that never put a unit on zero number, because
0is equal to0px,0%,0remand etc.
That's it! Hopefully those feedback will improve your skill!
Happy Coding and Keep Learning!
Marked as helpful
0
