Design comparison
Solution retrospective
Hello, Frontend Mentor community,
Here is my solution for the profile card component. Any feedback that can help me improve my skills is welcome.
Community feedback
- @VCaramesPosted about 2 years ago
Hey @vjeanty02, some suggestions to improve you code:
-
The “30-day, hassle-free money back guarantee” is not a heading. It should instead be wrapped in a Paragraph Element.
-
The button was created with the incorrect element. When users click on the button they should directed to a different part of your site; that Anchor Element will allow this to happen.
-
Add
padding
to your Body Element to prevent your component touching the side's of the screen.
Happy Coding! 👻🎃
Marked as helpful0@vjeanty02Posted about 2 years agoHello @vcarames,
"30-day, hassle-free money back guarantee" seems like a heading.
I admit that I don't know when to use headings and paragraphs. That's why I consider short text as heading and long text as paragraphs. And if the text stands out from the other texts, I also consider it a heading.
This technique sometimes confuses me. Do you have a tip to help me differentiate them more easily?
If not, thanks for your comment, and I will make the changes you recommended.
Please, can you take a look at my solution of : Four card feature section All feedback is a support that can help me improve.
0@VCaramesPosted about 2 years ago@vjeanty02
Normally, you would have a designer who would tell you what is a heading and what is not. In this case. Think of headings, like book chapters titles.
Each one tells you what the chapter will be about.
So the "30-day, hassle-free money back guarantee" does not tell you what that section will be about but rather reinforces the Join our community", heading .
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord