single price grid component challenge (I followed tutorial)

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @spilltheteapls!

  Your project looks great!

  I noticed that your card is not in the middle of the page. Here's a very efficient way to center the card:

  • Apply this to the body (in order to work properly, you can't use position or margins):

  body {
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0
• 

  raya•2,870

  @rayaattaPosted 11 months ago

  hello spilltheteapls, congratulations on completing another challenge 🎉 I have two suggestions that might help you.

  1 I recommend that you should follow the mobile first workflow when working on your challenges and then advance to larger screen sizes, you can learn more about it here mobile first

  2 Make your html more semantic. divs do not carry any semantic value. They are used solely for decorations. You should replace some of them with tags such as <article> and <section> You can find out more about these tags and more in this article📑.

  I hope this helps 🙃

  Otherwise nice solution 👏

  Marked as helpful

  0