Design comparison
Solution retrospective
Feel free to leave any feedback regarding my solution. It is greatly appreciated.
Thanks in advance, cheers
Community feedback
- @ChamuMutezvaPosted over 2 years ago
Greetings Shashree
- The role attribute describes the role of an element in programs that can make use of it, such as screen readers or magnifiers. By default, many semantic elements in HTML have a role; for example, <input type="radio"> has the "radio" role. Non-semantic elements in HTML do not have a role; <div> and <span> without added semantics return null. The role attribute can provide semantics. Some of the roles that you have used , such as
role="information regarding subscriptions" , container
are not recognized. For a list of recognized aria roles , see the mdn roles list - use semantic html ahead of elements such as div. For example , instead of using a div with a role of header, that should have been a
header
element - a button does not need to have a role of button, it has all the functions of a button already.
2 - The role attribute describes the role of an element in programs that can make use of it, such as screen readers or magnifiers. By default, many semantic elements in HTML have a role; for example, <input type="radio"> has the "radio" role. Non-semantic elements in HTML do not have a role; <div> and <span> without added semantics return null. The role attribute can provide semantics. Some of the roles that you have used , such as
- @tesla-ambassadorPosted over 2 years ago
Hey Shashree! Great solution! I think the only problem is that it isn't responsive. Consider using media queries in your css so that you can style the website for different screen sizes. Otherwise, this was a nice solution to flex your grid knowledge you're on your way to become the best! Happy coding and fun doing it!
0 - @sparrowslPosted over 2 years ago
Hi, Shashree
The site is not responsive on mobile devices. can you take a look at it. Everything seems great apart from the code report and the points Chamu stated,
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord