Design comparison
Solution retrospective
I didn't use grid because I'm not comfortable with but I'm training to be better.
If you have any advices please tell me.
Community feedback
- @MohamedAridahPosted over 2 years ago
Hello @Gab-Ferreira, You did a very good job for this solution, yours solution also is Responsive. So will done👏🎉.
However i have some notes for you:
- it was very obvious that
padding
andbox-shadow
were too much. Try to reduce the padding forheader
,.sign-up
and.why-us
elements.
.card { box-shadow: 0px 8px 22px 5px rgb(0 0 0 / 12%) }
-
instead of using
<button>
element for sign up. you better use<a>
element for this because this action may lead to separate page to complete the sign process. -
.texts-whyus
instead of using<div>
andbr
. you should use unordered list<ul>
instead.
<ul class ="texts-whyus"> <li>Tutorials by industry experts</li> <li>Etc...</li> </ul>
I hope this wasn't too long for you, hoping also it was useful😍.
Goodbye and have a nice day. Keep coding🚀
Marked as helpful0@Gab-FerreiraPosted over 2 years ago@MohamedAridah I definitely have to improve, thanks a lot.
0 - it was very obvious that
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord