Single price grid component

Community feedback

• 

  Mohamed ELIDRISSI•455

  @elidrissidevPosted over 2 years ago

  Hey Imad 👋

  Hope you're doing well. You did a great job on your solution! I usually see some common mistakes in most solutions, but not this one!

  Here are my notes:

  • type="submit" is meant to be used with buttons inside a <form>, in this case there is no form so I'd suggest you set it to type="button".

  • The "Why Us" section is meant to be a list of features of this fictional website, therefore I think a <ul> will be more semantically correct instead of a <p>.

  • Some page elements are styled with their class names whereas others are styled by their tag name, this makes the CSS difficult to read as you'll need the HTML as a reference. Consider leaning more towards classes to style your elements, as they are re-usable and they make your code easier to understand.

  • The ch unit has some specific use cases, but generally I'd stay away from if not needed and just use other units like rems or ems.

  Hope this helps you, if you have some questions feel free to reply. Good luck!

  Marked as helpful

  1

  ---

  

  imad•3,330

  @imadvvPosted over 2 years ago

  Hey Mohamed 👋, Thanks for the feedback it's really hope, I update the solution. I have struggles finding names for classes, so I end up mixing things for practice and learning reason.

  0

  

  Mohamed ELIDRISSI•455

  @elidrissidevPosted over 2 years ago

  @imadbg01 You're welcome! Indeed, coming up with class names can be difficult at times, but remember, practice makes perfect ;)

  1