Single price grid component

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Mukesh, It looks good!...

  My suggestions:

  • I suggest you put the Why Us content into the list item to add more semantics to your project, Div's don't do much for semantics but a list is much more meaningful..:

  <ul class="why-us-list">
     <li>Tutorials by industry experts</li>
     <li>Peer & expert code review</li>
     <li>Coding exercises</li>
     <li>Access to our GitHub repos</li>
     <li>Community forum</li>
     <li>Flashcard decks</li>
     <li>New videos every week</li>
  </ul>
  

  • Page should contain a level-one heading, Change h2 to h1

  <h1 class="heading">Join our community</h1>
  

  You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • Heading levels should only increase by one, Use h2 instead of h4... Ordered headings make it easier to navigate and understand when using assistive technologies.

  • I suggest you add cursor: pointer; to the button, The cursor indicates to users there is an action that will be executed when clicking on it

  Hope this is helpful to you... Keep coding👍

  Marked as helpful

  1