Design comparison
SolutionDesign
Solution retrospective
Any feedback is appreciated guys!
Community feedback
- @mattstuddertPosted over 4 years ago
Nice work on this challenge! Here are a few pointers after taking a look at your code:
- Where you've used a
h2
with an ID of "intro-text", I would recommend using a paragraph. I wouldn't describe that piece of content as a heading. - Avoid using IDs as CSS selectors. They have high specificity and can't be reused on the page, so they're not good for the purpose of styling. Instead, I'd recommend sticking to class, attribute, pseudo, and type selectors. Using these will help keep your CSS more maintainable.
- Have you ever tried using
min-width
media queries instead ofmax-width
? It's quite a common workflow with front-end developers to use them and work mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users, which can be a nice performance gain.
I hope that helps. Keep up the great work! 👍
0 - Where you've used a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord