_nehal💎• 6,710
@NehalSahu8055
Posted
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨ Use Semantics for the proper design of your code.
<body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
</body>
you can wrap up .attribution div to footer.
or alternatively
<body>
<div class="container" role="main">
/html code goes here: 📃
</div>
</body>
➨ Replace height with min-height:100vh in the body to properly center the card.
➨ Use max-width instead of width to make your card responsive.
➨ Remove width:100vw.
- Setting an element's
width to 100vwmakes it as wide as the current viewport. But doing that is bad practice. First, it is almost always unnecessary. A block element, by default, already takes up all the available width. Setting the width manually is not needed in that situation.
I hope you find this helpful.
Happy coding😄
Marked as helpful
0
