Single price grid component

Community feedback

• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hi👋

  I have checked out index.vue here are some suggestions to help improve your code.

  1 I noticed

  <div class="wrap-description mt-20">
  

  This is actually supposed to be an <ul> Since it shows a list of services provided by the community.

  2 I noticed you used plenty of divs and spans to define the different sections of the page. divs and spans do not carry any semantic value.

  You should replace them with more semantic tags.

  Check out this article

  I hope this helps ✌️

  Marked as helpful

  0

  ---

  

  Sakti•190

  @saktiajadehPosted 10 months ago

  Hi @rayaatta, Thanks for the feedback Im happy to your tips to improve my work and i will trying to use semantic tags in the next update

  1
• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hello Sakti!, nice solution 👏.

  The problem is that currently the link to your GitHub repository is invalid.

  I tried to head over and check out the code and it led to the GitHub 404 error page.

  Please update the link.

  Happy coding 🙃

  0

  ---

  

  Sakti•190

  @saktiajadehPosted 10 months ago

  Hi @rayaatta, im sorry i didn't realize my github link cant be open publicly, but i already updated it. thanks mate

  1