Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <section class="main"> with the main tag, the first <h4> with <h1> and the rest of the ,<h4> with <h2> to fix the accessibility issue. click here for more on web-accessibility and semantic html
Give the body a background-color. Use the colors that were given in the styleguide.md found in the zip folder you downloaded
body{ background-color: hsl()}
To center .main on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .main on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
To center .main on the page using grid: body{ min-height: 100vh; display: grid; place-items: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
You forgot to add a media query for the mobile design.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord