Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- Every site should always have ✅ a
main
element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will wrap the the entire section ⚠️.
More Info: 📚
- Avoid skipping heading levels ⚠️. Always start with the
h1
(which can only be used once) and you will go down the hierarchy level depending on the heading’s importance.
- It is best practice ✅ to use,
classes
for styling purposes, while usingids
solely for JavaScript.
- The “30-day, hassle-free money back guarantee” is not a heading❌. It should instead be wrapped in a
paragraph
element.
- The button was created with the incorrect element ❌. When users click on the button they should directed to a different part of your site; the
anchor
element will allow this to happen.
More Info:📚
- The “Why Us” list needs to be created using an
unordered list ⚠️
element along with thelist item
element.
- Implement a "Mobile First" approach 📱 > 🖥
Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.
More Info: 📚
- For improved accessibility 📈 for your content, it is best practice to use
em
✅ formedia-queries
. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord