Single price grid component

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Nice work, Alex! You've done a really good job. Here are a few pointers after taking a look at your code:

  • You've got h1 and h3 headings, but no h2. Avoid skipping heading levels unnecessarily as it can cause accessibility issues with the content hierarchy.
  • You've made the site responsive, which is awesome. Your media query is currently set to this: @media screen and (min-width: 375px) and (max-width: 992px), which means the layout breaks for anyone on a screen smaller than 375px (like an iPhone 5 or 6). You'd be better just to remove the min-width condition entirely.

  Really nice work on the challenge. Your solution looks great. Keep it up!

  1

  ---

  

  Alex Piter•130

  @AlexrjjPosted almost 5 years ago

  @mattstuddert Thank you very much! I'll follow your tips and update my Github repo.

  Thank you again, mate!

  0