Alexandra• 510
@Alexandra2888
Posted
Hi! Congrats for finishing the challenge! Your solution is very close to the design! Here are a few things I think you can improve:
- reset also pseudo-elements with *::after, *::before,
- implement BEM naming convention in CSS so your code will be more maintainable & cleaner,
- use relative units (em, rem) instead of px not only for font-size. Px are preferred when you code for newspapers/magazines,
- add aria-label for buttons for screen-readers. Happy coding!
1
P
Piwko Marcin• 180
@PiwkoO
Posted
@Alexandra2888 Thank you for taking your time and checking my solution. From the points you mentioned, I want to clarify 3 of them.
- I didn't reset pseudo-elements because of the low complexity of this project, but I agree that it's good practice to do especially in bigger projects,
- In this project, I intentionally didn't write BEM, but tried to use OOCSS because it's easier to practice on smaller projects and it's also good to know different methodologies,
- I think when you have text in the button tag the readers should use it. I followed Mozilla docs for this, but you're absolutely right when this isn't the case (eg. icon inside button instead of text).
Don't get me wrong. Your feedback is precious to me but I just wanted to explain the logic behind my decisions.
You're point about relative units made me think so thank you very much for it. I already started reading articles so I could understand this concept in more detail and write better code.
Thank you and happy coding!
1
