Single price grid component

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @sliyarli!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Use <h1> for the main title instead of <h2>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  1
• 

  Manoj Kumar Singh•970

  @dev-mksinghPosted 9 months ago

  Hey @sliyarli, well i'm not offending you, but it's my suggestion that first make your concepts clear with CSS and then dwell into any CSS framework. In your project, you are using Bootstrap, but i think you didn't took time to read the documentation properly. Doc row Bootstrap here you will see it clearly explains that using row class will involve gutters (you can say margins) . Now you need to remove that gutters. Read here

  Columns have horizontal padding to create the gutters between individual columns, however, you can remove the margin from rows and padding from columns with .no-gutters on the .row.
  
  

  because of this your border-radius is not working. Thus please clear the CSS concepts first. Hope this will be helpful Happy coding

  1

  ---

  

  Shahin Aliyarli•680

  @sliyarliPosted 9 months ago

  Thanks, @dev-mksingh, in my next project (Four card feature section) i found out about the gutters, in other words, root of the problem that i mentioned in this submission. I think the best way to study a concept is making projects (a.k.a getting hands dirty) and not just reading some paragraphs. Once again, thank you for reminding me of the importance of this and directly answering my question.

  0