Design comparison
Solution retrospective
Any feedback is appreciated.
Community feedback
- @AgataLiberskaPosted over 3 years ago
Hi @Tejas-117, well done on this solution, it looks great! The only issue I found is the missing outline on button focus - it's a bad practice to remove the default focus styles without providing an alternative, custom style - a lot of people rely on them when navigating the page :)
0@Tejas-117Posted over 3 years ago@AgataLiberska Thanks for the feedback. Your suggestion is to keep the default outline?
0@AgataLiberskaPosted over 3 years ago@Tejas-117 or set your own style if you want it to look nicer and match the design better. Have a look at the buttons in bootstrap for example - they all get an outline matching the button, they look nice but they're also visible - I've seen that on some websites focus styles are just a copy of hover styles and that may not be clear enough for some users.
1@Tejas-117Posted over 3 years ago@AgataLiberska Thanks, I will improve these in next solutions.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord