Responsive Pricing Card

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The min-width: 100vw property for body is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • So feel free to remove min-width: 100vw style rule from body this will help you to write efficient code and makes your code more reusable.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Dumte Nwidoobee Joshua•100

  @DumtePosted over 1 year ago

  @0xAbdulKhalid thanks Bro.

  By my usual styling, I always center a div or an element my applying ```min-height: 100vh; display: grid; place-items: center;

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div id="card"> with the main tag, <h2> with <h1> and <h4> with <h2> to fix the accessibility issue. click here for more on web-accessibility and semantic html

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded, you forgot to give the body a background color. give p a line height value for the line spacing between the text

  To center #card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units click here

  There is no need to give #card a height value in the media query , increase the padding value for the sections, their padding values is a good placement of that.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0