Skip to content
Submitted over 1 year ago

Single price grid component

Bárbara Damasceno•320
@barbaradamasdev
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Single price grid component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi!

In this challenge I was thinking if I use flexbox too much (:D). I was thinking that sometimes I can use margin to give the space between things, but use "gap" looks like work better.

Is it a "problem" or maybe can be considered a bad code if I use this a lot? Is better just use margin for exemple even though I use just margin-top and look ugly when you inspect the element?

Other question about a clean code. In the line 95 (style.css) I prefered to use the code just inline, for some cases is ok? Or it's considered a bad practice?

Please give me your feedback, it'll help a lot. Thank! :)

Community feedback

  • ApplePieGiraffe•30,545
    @ApplePieGiraffePosted over 1 year ago

    Hi there, Bárbara Damasceno! 👋

    Nice job on this challenge! 👏

    Haha I don't think you can use too much flexbox unless you are using it the wrong way or there is another tool that is better for the job. 😄 I definitely prefer using flexbox gap over margin in most cases.

    Related to your questions about your styles, I would recommend looking into using a code formatter such as Prettier. It'll help you format your styles nicely at the click of a button and you won't have to spend time doing that yourself. 😉

    Also, you may want to wrap the content of your page in a main element as that is considered a best practice and will help to clear a lot of the issues in your solution report.

    Hope you find this helpful. 😊

    Keep coding (and happy coding, too)! 😁

    Marked as helpful
    2
    Bárbara Damasceno•320
    @barbaradamasdevPosted over 1 year ago

    @ApplePieGiraffe Thanks, you helped a lot. I'll take a look in the Prettier and the main element. I appreciate it.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord