Design comparison
Solution retrospective
Hi all, I would like to know if my code structure is up to standard conventions and are there any room for improvements. Thank you in advance!
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @pohyongzhi!
You did a very good job there!
I have just one very simple suggestion for improvement:
- Since the sign up button is a clickable element, it's nice to give the user a visual indication as well as a light color shift. Something like this:
button:hover { background-color: /* color here */; cursor: pointer; }
I hope it helps!
Other than that, you did a great job!
Marked as helpful1 - @rayaattaPosted 11 months ago
Hi Yong Zhi,congrats completing this challenge๐.* A bit of advice you might be interested in. 1.every html document should have only one
<h1></h1>
element to indicate what the page is about then you continue off with theh1-h6
This is important for assistive technology such as screen readers to identify what the page is all about. 2.Your<div class="paragraph-group">
should actually be an<ul></ul>
withlist-style-type: hidden
in css. This is because it indicates to assistive technology that it is a list not just a line up of divs. I also appreciate how much effort you put into making your html more semantic. Your solution is greatMarked as helpful1@pohyongzhiPosted 11 months ago@rayaatta Hi raya, thank you for the comment. I have amended my code! ๐
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord