You need to fix up the html on this. It’s a really important skill to practice - translating a design into the most appropriate meaningful html elements.
For example
- think through heading order - this should only have one h1
- why is sign up a button? What would happen on click? Is that the right element?
- it’s definitely not a paragraph in the last box. What would be better?
Use css grid for this. That means the 3 boxes should be direct children of the main grid.
Never ever have font size in px. Really important. Use rem
Use max width in rem instead of %. Get back control.
No heights at all in this. Never limit the height on elements that have text content inside
Marked as helpful
@littledragonshrimp
Posted
@grace-snow
Thanks Grace!
I'm going to rework this and I am currently converting most of the percentages/px in my current project to rems before I return to this one.
Just 2 questions:
- If the sign-up isn't a button, should this be an anchor tag that looks like a "button" since in theory, this would link to a page with the sign-up content?
- Why is paragraph not correct in the last box? I don't think a span, div, or article works here but I couldn't tell you why.
@littledragonshrimp exactly. If navigation is triggered on click that means it's an anchor tag
The last box needs a list
There are 100s of html elements to become familiar with and it will take time. But whenever you get a design try to take time imagining it with no styling, as pure content. Most of the time you'll be able to work out what it would be in a standard document and that will really help you with html element choice
@littledragonshrimp
Posted
@grace-snow After actually re-reading the content, I completely understand why this is a list now. Thanks!