Design comparison
Solution retrospective
Any recommendation will be appreciated
Community feedback
- @vanzasetiaPosted over 2 years ago
Excellent work on this challenge, Geraldo! Your solution is responsive and looks great! π
In your CSS, I noticed this selector
.container .card .card-2
which would be much be as.card-2
. I would strongly recommend keeping the CSS specificity as low and flat as possible. High specificity will make your stylesheet hard to maintain.Try to use
rem
or sometimesem
unit instead ofpx
. Usingpx
will not allow the users to control the size of the page based on their needs.I highly suggest writing the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.
That's it! I hope this information is useful! π
Marked as helpful1@GeeraldvPosted over 2 years ago@vanzasetia Your comment is very useful, these points will make me improve a lot as a frontend, I hope more reviews in my challenges. βπ»π¨π»βπ»
1 - @dostonnabotovPosted over 2 years ago
Except for bold font-weight, your site looks great. I think, it is good add font-weight: bold; to your title, button and e.t.c., in order to match with the solution.
Marked as helpful1@GeeraldvPosted over 2 years ago@dostonnabotov Thanks for your review, I'll take apply the changes.!!
0 - @Kamasah-DicksonPosted over 2 years ago
Your solution looks good on smaller devices. Good job thereπ Keep codingπ
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord