Submitted almost 2 years ago
Responsive Single price grid semantic HTML and CSS
@NathanMartinez
Design comparison
SolutionDesign
Solution retrospective
Any feedback or suggestions are greatly appreciated!
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
section
element is being used incorrectly ⚠️ and not needed for this challenge .
- It is best practice ✅ to use,
classes
for styling purposes, while usingids
solely for JavaScript.
- The headings are being used incorrectly ❌. You can only use the <h1> heading once per page ⚠️. So For this component, you will only use the <h1> for “Join our community” and <h2> for “Monthly Subscription” and “Why us.”
- The “30-day, hassle-free money back guarantee” is not a heading❌. It should instead be wrapped in a
paragraph
element.
- The button was created with the incorrect element ❌. When users click on the button they should directed to a different part of your site; the
anchor
element will allow this to happen.
More Info:📚
- For improved accessibility 📈 for your content, it is best practice to use
em
✅ formedia-queries
. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0@NathanMartinezPosted almost 2 years ago@vcarames
Hello,
Thank you so much for the feedback!
I have updated my code based on your suggestions.
If you can take a look and let me know if I have made the proper updates I would greatly appreciate it!
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord