Design comparison
Solution retrospective
Hello World!
Very happy with the result. Any feedback will be really appreciated!
Have a nice day y'all! ๐ โ๏ธ
Community feedback
- @correlucasPosted about 2 years ago
๐พHello Francesco, Congratulations on completing this challenge!
Your solution its almost done and Iโve some tips to help you to improve it:
The approach you've used to center this card vertically is not the best way, because using margins you don't have much control over the component when it scales. My suggestion is that you do this alignment with
flexbox
using the body as a reference for the container.The first thing you need to do is to remove the margins used to align it, then apply
min-height: 100vh
to make the body height size becomes 100% of the screen height, this way you make sure that whatever the situation the child element (the container) align the body withdisplay: flex
andalign-items: center
/justify-items: center
.body { display: flex; place-items: center; min-height: 100vh; font-family: 'Karla', sans-serif; background-color: var(--light-gray); flex-direction: column; align-items: center; justify-content: center; }
โ๏ธ I hope this helps you and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord