Design comparison
SolutionDesign
Solution retrospective
Suggest any better ways of implementing this if any. I have used grid for desktop view and a flex for mobile version.
Community feedback
- @GerbenDolPosted over 4 years ago
Hey there! First of all: your solution is looking really good! 💪🏻
There's a few things I'd change:
- Remove the width on the body on mobile, so that the content is centered
- Try a mobile first approach: you could make the mobile layout with flexbox or grid at all, since they're all just block elements. On bigger screens you activate your grid and make that work for the layout
- Try and have less duplicate code. In your media queries you're overwriting some styles with... the same styles. (for example your
.main-container
hasmargin-left: auto; margin-right: auto;
on it already, so no need to set that again in your media query.
Keep up your good work! 😁
1@kpcprasadPosted over 4 years agoThank you so much @GerbenDol . These suggestions help me a lot to improve my skills.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord