Design comparison
Solution retrospective
Hello , feedbacks are welcome and also need to an honest review on my GitHub page if its well organized, Thank you.
Community feedback
- @bramizdevPosted over 1 year ago
Nice Job!
I'm not an expert but here is a brief feedback.
You are missing a
h1
element (Or I guess you use it for the price)The
h1
should be the title of your page and not be used for styling purposes.Having a clear and descriptive
h1
element on each page is important for SEO, accessibility, and user experience reasons. It helps search engines, assistive technologies, and users understand the main topic and purpose of the page, and can ultimately lead to a better overall experience for everyone who visits the page.Nested elements inside
span
tagsI guess the correct way to do it is like this:
<h1>Title of this <span>Page</span><h1>
The
span
element is a generic inline container element in HTML that is used to group together text or other inline elements and apply styles or attributes to them. It has no inherent semantic meaning and is typically used for small pieces of content or for applying styles to specific parts of a larger block of text.I hope this helps!
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord