Design comparison
Solution retrospective
Any feedback or suggestion will be welcome.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello there, Makson! π
Nice work on this challenge! π Your solution is responsive and looks great! It's good that you using the mobile-first approach and using
rem
as the main unit in the stylesheet! Good job! πSome areas that can be improved.
- There should not be text in
span
anddiv
alone; instead wrap the text with a meaningful element. - I would highly recommend using the dollar sign directly instead of using character references. The site is using the UTF-8 character set which supports all symbols. It's also good for SEO as well. So, just use the dollar sign.
I hope this information is useful! Keep up the excellent work! π
Marked as helpful0@Makson19Posted over 2 years ago@vanzasetia Your tips are very helpful. Thanks so much for sharing them. I will make sure to adjust the code. π
0@vanzasetiaPosted over 2 years ago@Makson19 No, problem! I'm happy that it's helpful for you! π
0 - There should not be text in
- @Kamasah-DicksonPosted over 2 years ago
Your solution looks so good on mobile and responsive. Good job there keep codingπ Happy codingπ
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord