Design comparison
SolutionDesign
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
- Remove
margins
from the#card
as this will not dynamically center the card. - To properly center the card.
- USING FLEXBOX
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
-
or alternatively
-
USING GRID
body{ min-height: 100vh; display: grid; place-items: center; }
-
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
. -
Use
Semantics
for the proper design of your code.
<body> <header> <nav>...</nav> </header> <main>...</main> <footer>...</footer> wrap up `.attribtution` div inside your footer. </body>
-
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google link. -
Replace
width
withmax-width
to make your card more responsive. -
Don't use
fixed height
as it may affect your design for responsiveness. -
Give breakpoint somewhere at 800px.
I hope you find this helpful.
Happy coding😄
Marked as helpful0 - Remove
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord