Design comparison
Solution retrospective
I have no question, but looking forward to seeing the industry standard.
Community feedback
- @malek-btPosted almost 2 years ago
Hey !, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:
1.To center a div, you can use grid like:
display:grid;place-items: center;
or you can use flexbox like this:display:flex;justify-content: center;align-items: center.
2.Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers.
3.I see you donβt have README. README is a very important aspect of making projects, especially if you want other people to see it. As the name says, itβs the first thing people read when interacting with the project, it is kind of a manual. You can include many things there like the languages you used, which dependencies you installed, what was the process like, and what did you achieve or learn. Frontend Mentor also has a pretty nice README template which you can use to tailor the one depending on your preferences.
4.Heading levels should only increase by one , So you can replace <h4> by <h3>.
The rest is good, I hope those tips will help you! π
Good job, and happy coding! π
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord