Single Price Grid Component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi There!

  I would recommend to host your website on Netlify or Vercel or GitHub page instead of using codepen, since it's much easier to preview your solution and it will make the Frontend Mentor reports a better accessibility issues.

  Some feedback:

  • For the 30-day, hassle free..., it should be a paragraph element, but with emphasize. You can use em tag for that.
  • Also you can merge the two paragraphs on the first section.
  • Heading order is very important. You should use h1, h2, h3 and so on. It's important for accessibility.
  • You should never change the root font size, since it can cause a lot of issues. Here's what an accessibility expert has said (Grace Snow):

  Yeah, I would never resize html/root font size down to 62.5% mainly because it is completely unnecessary, and it carries risk. You are correct you can mitigate against the accessibility issues by scaling the font size back up with 1.6rem on the body, BUT

  • not all elements inherit font size from the body so you have to remember to manually scale up them as well
  • you need to do extra testing for that reason
  • any rem sizes on third party components or plugins you bring in will need loads more overrides because you’re changing an established default, you cannot guarantee it will work correctly for everyone on every device, operating system, browser and tech set up Basically it comes with a lot of risks for almost no benefit.

  There is no reason 1rem needs to equal 10px. As soon as you start thinking entirely in REM - building for alignment, proportionality and spacing - rather than thinking in pixels, the whole point disappears.

  That's it! Hopefully this is helpful!

  0

  ---

  

  President Tree•360

  @PresidentTreePosted about 3 years ago

  @vanzasetia, I appreciate your feedback and I will make the edits when I can.

  I do have a question, though: I have thought about hosting through GitHub recently, but I can't seem to figure out how it works. I've looked at the information pages before, but it leaves questions unanswered. Could you explain it to me? Does it cost money? How would I access the site?

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  @PresidentTree GitHub pages are free and to make your website live follow this steps:

  • Go to the repository that you want to host.
  • Click the Settings tab
  • Then, click Pages
  • Scroll down and search for the Source
  • Then, select the branch and if your html is in the root then just click Save button.
  • You can check by typing the url, which is following this formula:

  https://username.github.io/respositoryname/
  

  That's it! Hopefully you can host your solution on GitHub Pages!

  Marked as helpful

  0