Single Price Grid Component

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, good work on this one. The layout is good in desktop and in mobile as well. No issue when resizing, but I second to what @Sahil-Yadav that there are extra white spaces on your container.

  Other suggestion/s would be;

  • Height. Right now, you are using height: 100vh in your #main-container selector which I really not recommend using. Since you are limiting the height based on the viewport. So when you open up in dev tools at bottom, your layout is squished in the top which is not really good. But the main problem is that, your grid-container is dependent on the size of the parent which is the #main-container. What would be better is that using a fixed height on your grid-container , using a unit like rem will be really so that it won't scale with the viewport and the content will not be destroyed.

  • Too many h1. Though before we really recommend not using h1 and I am still against using it multiple in a page because using it multiple causes some sort of problem for people who uses screen reader. I read this when Grace commented on someone as well for using multiple h1.

  • br. I see that you used many br in your why us section. Though it works but I think it will be better if you made use of like ul. Because if you look at it, those sentences is like a list. So why not use ul or ol right, semantically it is really good.

  But still, you did a good job. But please consider my first suggestion about using fixed height okay. We want layout that don't get destroyed, we want them to be good at all users even when viewport is problem^^

  1

  ---

  

  Abhijit Paul•195

  @ethabhijitPosted over 3 years ago

  @pikamart Thank you buddy. I will remember your advise.

  0
• 

  Sahil Yadav•70

  @Sahil-YadavPosted over 3 years ago

  It's good but there is a lot of unnecessary white space that shouldn't be there. That is easy to fix.

  0

  ---

  

  Abhijit Paul•195

  @ethabhijitPosted over 3 years ago

  @Sahil-Yadav Thanks a lot for you suggestion.

  0