Single Price Grid Component

Community feedback

• 

  Fatih•865

  @fatihcandevPosted over 3 years ago

  Looks good 👍🏼 I see that the body doesn't take up the height of the screen and the card doesn't look centered because of it. You might wanna fix that.

  1
• 

  Michael Bishop•1,080

  @MikeBish13Posted over 3 years ago

  Great job, Helin! Very neat implementation of grid and hopefully you can see how simple it makes creating layouts!

  Couple of things to consider:

  • I would consider adding a padding to the top and bottom of each of your sections, rather than adding it individually to each element - it'll save you a lot of time in the future and leaves you less prone to errors/it's easier to debug.
  • Similarly, I would space out the individual elements within the containers using a margin top/bottom as opposed to padding. If the spacing between the elements is the same (eg 1.5rem), I would consider grouping these together in a single CSS declaration - again, it's less code and stops you repeating yourself.

  Hope that helps!

  0