Single price grid component

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Victor,

  Well done :D

  A few tips from me below:

  • instead of this div class="container" use just the main tag;
  • creating clickable element by div it is not a good practice (accessibility) => use the tags dedicated to it like a link or button but in this project I'd suggest to use a link, why? check this article from the blog CSS-tricks: A Complete Guide to Links and Buttons;
  • names of classes are not readable and descriptive I'd recommend using BEM naming convention;
  • text "per month" is not in the middle of the price;
  • check your project by the inspector in your browser on different devices => it doesn't look well, margin, button, layout etc.
  • the same problem with the width and height (check my comment in four cards feature section challenge).
  • try to start building your project from the mobile first.

  Ps. Please, don't forget to upvote any comments on here that you find helpful.

  Greetings :D

  1