Design comparison
Solution retrospective
Hey! I am Reza 🙂 I just recently started to learn web-development and would like to get every little help out there. So if you have the time, feel free to look over my project/projects and give me some advice to get better as fast as possible.
Project #10: Some questions for this "Single-Price-Grid" project:
- Did I center everything right, or was there a easier way?
- Was there a easier way to design some things in way less code?
- What did I do completely wrong, and just have luck within this project?
- What would you do different?
I appreciate it✌️
Community feedback
- @gregoriofrancisco99Posted almost 2 years ago
Hello, Reza! Gotta tell you, loved your solution. And the comparison screenshot speaks by itself! Congratulations! Even tough the design looks really good, I took a look at your code and I will raise some points.
You should try to wrap all your main content inside a
<main>
.And if you have more than one
<section>
you should consider wrapping them inside an<article>
.<h1>
are the top level heading in a page, and there should be only one of it. and<h2>
is what follows it on the heading hierarchy. Clique here to get to know them all (from<h1>
to<h6>
) and what are they meant for.And I saw you used a
<button>
for the sign up. And it's not really wrong, but for me, I think you should use an<a>
. Because it seems it will take the user somewhere else, or open some other content.I saw you used an
<ul>
for the last card. That was awesome!!! 🎉Well, those are my comments for this solution. And remember... Keep coding 💻
Marked as helpful0@rezajaberPosted almost 2 years ago@gregoriofrancisco99 Hey my friend! I want to thank you so much! This was not just really helpful but it also showed me that you really did look over my code and took some time to help me. This just feels awesome and I really appreciate it🔥
I will definitely remember these tips and use them for the next project! Again a huge thanks and stay active ✌️
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord