Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="grid-container"> with the main tag to fix the accessibility issue. for more on semantic html visit https://web.dev/learn/html/semantic-html/
The body has a wrong background color
To center .grid-container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
Give the paddings, margins and width a fixed value instead of a percentage value eg:
.grid-container{ width: 700px} .grid-item1{padding: 0 20px}
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_ToHope am helpful
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@bbenbboyPosted almost 2 years ago@Hassiai Thank you Hassiai, you are a lifesaver.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord