Single Price Grid Component

Community feedback

• 

  P

  Alper•1,010

  @adonmez04Posted over 1 year ago

  Hi, @Deepali25-K. It's a good solution. Keep coding. I have some suggestions for you.

  The HTML Structure

  • You can use one section tag inside of the main tag and create div to inside of the section. Because section tag divides the main to different parts. They aren't different parts of the main, they're different parts of the section.
  • You should use h1 tag once on one page. But you can use h2-6 tag limitless. This is necessary for the hierarchy of the page. Screen readers and search engines use this hierarchy to index for the page.
  • You can use ul>li instead of p wall:) I used p when my first solution, I completely forgot this part like you. I'm sure you just forgot about this part. I just wanted to remind you.

  The CSS Properties

  • Your CSS part looks very good. Actually I always see strong HTML and weak CSS but in your case, it's totally opposite. idk why, maybe you could focus a little more on HTML.

  • As I said, in the CSS part, all is well. Just a little advice: You can use grid-template-rows: auto auto auto instead of grid-template-rows: 1.1fr 1fr 1fr;. You don't need to calculate the height value. You can focus on the elements' margin and padding values and browsers will calculate the appropriate height value for every element. 1.1fr is uncessary I think.

  I hope these will help you to improve your perspective. Keep coding. All the best.

  Marked as helpful

  0
• 

  Deepali Panchal•310

  @Deepali25-KPosted over 1 year ago

  Thank you for taking the time to provide feedback and suggestions on my solution. I appreciate your insights and will certainly keep them in mind going forward.

  I agree with your suggestion that the HTML structure could be improved by using a section tag inside the main tag and creating divs within the section. I also understand the importance of using the h1 tag only once on a page and using h2-6 tags for hierarchy purposes.

  You're right that using ul>li instead of p for the wall of text would be more appropriate, and I will ensure to implement that in my future coding.

  I'm glad you found the CSS part well-written. I will keep your advice in mind and try to use grid-template-rows: auto auto auto instead of calculating the height value.

  Overall, I appreciate your feedback and suggestions, and I will work to incorporate them into my future coding.

  1