Design comparison
SolutionDesign
Solution retrospective
Any tips and feedback are welcome.
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @muhabibta 👋🏻
I have some suggestions to help you fix the accessibility issues and some other things.
- In your markup,
<div class="container">...</div>
should be<main class="container">...</main>
and this will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues. - Next, I suggest using
<h2>
or<p>
instead of<h4>
, because headings in HTML have to increase gradually, such ash1, h2, h3….
. - Lastly, let's bring the card to the center of the page, and here's how to do it:
body { font-size: 16px; font-family: "Karla", sans-serif; background-color: var(--Light-gray); min-height: 100vh; display: flex; align-items: center; justify-content: center; }
and once you do this, you can remove
margin: 8% auto;
from.container
.I hope this was helpful 👨🏻💻 overall, you did a nice job, keep it up. Cheers 👾
0 - In your markup,
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord