Design comparison
SolutionDesign
Solution retrospective
Making some progress here, any feedback is welcome :)
thank u all <3
Community feedback
- @vanzasetiaPosted almost 2 years ago
Hi, Atlas! 👋
I have some feedback on improving this solution.
- "30-day, hassle-free money back guarantee" should be a paragraph element. It is not a sub-title or
<h2>
. - "Monthly Subscription" and "Why Us" should be
<h2>
. - Avoid inline styling. Put all the CSS in the external stylesheet.
- Never use
px
unit for font sizes. Userem
orem
instead. Relative units such asrem
andem
can adapt when the users change the browser's font size setting. - Remove
font-size: 16px
from the<body>
styling. It is already the default styling. As a side note16px
means the same as the default body's font size which is1rem
.
Next time, I recommend writing the CSS using the mobile-first approach (using
min-width
media queries). The mobile layout is simple. So, you only need to add more complex styling for larger screen sizes.Read more — Responsive design ground rules | Polypane
I hope you find this useful. 🙂
Marked as helpful1 - "30-day, hassle-free money back guarantee" should be a paragraph element. It is not a sub-title or
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord