Single price grid component

Community feedback

• 

  Vanessa M.•90

  @mendezpviPosted 11 days ago

  Hi Hager Yasser, here are some observations:

  1. Create a separate CSS file.
  2. IDs should be reserved for JavaScript interactions. Use classes (class) instead for styling.
  3. Use semantic tags:

  • id="main-container" should be <main>.
  • id="firstRow" or similar IDs should be <section>.

  4. Fix the content structure:

  • id="offers" replace it with an <h2>
  • id="tutorial" appears to represent a list; replace it with an unordered list <ul> and use <li> for its items.

  5. In the href attribute of the link inside the attribution section, include the URL to your repository.
  6. No need to reset the body padding, browsers already apply a default padding of 0, so resetting it is unnecessary.
  7. The current background color doesn’t match the design. Make sure to use the color specified in the project’s style guide.

  Happy coding!

  Marked as helpful

  0